Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreaming channel send/recv events #23

Open
chabbimilind opened this issue Apr 3, 2020 · 2 comments
Open

Upstreaming channel send/recv events #23

chabbimilind opened this issue Apr 3, 2020 · 2 comments

Comments

@chabbimilind
Copy link

This is a very useful feature. Was there any effort to upstream the runtime changes to upstream? It would greatly help to see the channel send/receive events in traces. Currently, channel events under the select statement do not appear in traces and using channels in select cases is very common.

@divan
Copy link
Owner

divan commented Apr 6, 2020

Hey, nope. I did a couple of attempts to update the code to the latest Go version, but it needed more time than I was able to devote to this.
The project was mainly for the educational purposes and for the article, so there is not much reason to keep it updated – not like people using this is on daily basis.

I'll try to find some spare time to see if I can update with tip, but if anyone willing to join me and send/discuss PR, I'd be more than happy.

@chabbimilind
Copy link
Author

@divan, this seems like one of the critically missing pieces in Go tracing. Although your project was educational in nature, the runtime changes solve an important problem in tracing. While I can try to migrate your runtime changes to the tip, probably you know the code best to make it happen, along with the necessary tweaks to the tools that depend on trace events. The issue with not upstreaming is that the adoption will be negligible. Hardly any code in production would be willing to use a patched go runtime, whereas including it in the upstream will immediately avail its benefits to all users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants