Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sufficiently large data sets cause x-axis labels to all have the same value #20

Open
portante opened this issue Sep 15, 2021 · 2 comments

Comments

@portante
Copy link
Member

With sufficiently large data sets, JSChart will use x-axis labels that are all identical, typically 00:00. When you zoom in the x-axis labels start to resolve to different values.

@webbnh
Copy link
Member

webbnh commented Sep 15, 2021

The x-axis labels appear to be coded with a fixed MM-SS format. The format should presumably be dynamic, based on the amount of time represented by the whole axis (e.g., if the whole axis is between 1 and 24 hours, then the labels should show hours and minutes (and probably omit seconds); if the whole axis is between 1 minute and 1 hour, then the labels should show minutes (and probably hours but not seconds); if the axis is between 1 second and 1 minute, then the labels should show seconds (and probably minutes, but not fractional seconds); if the axis represents less than a second, then it should show fractional seconds. (And, hopefully, we don't need to deal with intervals greater than 24 hours, but, if we do, then it should show days and hours.)

@ndokos
Copy link
Member

ndokos commented Sep 15, 2021

The format should also include an indication of what the units are: does "01:00" mean one minute and zero seconds or one hour and zero minutes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants