From 2cf3814beb95ae2de66b23ae872472337e4e6f8f Mon Sep 17 00:00:00 2001 From: Andy Davidoff Date: Tue, 15 Jun 2021 19:48:55 -0400 Subject: [PATCH] fixup fail logic --- balls/runner.nim | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/balls/runner.nim b/balls/runner.nim index 2e39384..23c96d0 100644 --- a/balls/runner.nim +++ b/balls/runner.nim @@ -398,17 +398,16 @@ proc shouldPass(p: Profile): bool = if ci and ballsFailFast: # neither cpp or js or nimscript backends are required to work if p.cp notin {cpp, js, e}: - # arc and orc are still too unreliable to demand successful runs - if p.gc notin {arc, orc}: - # danger builds can fail; they include experimental features - if p.opt notin {danger}: - case MajorMinor - of "1.4": - if p.gc <= orc: - result = true - of "1.2": - if p.gc <= arc: - result = true + # danger builds can fail; they include experimental features + if p.opt notin {danger}: + result = true + case MajorMinor + of "1.4", "1.3", "1.2", "1.1", "1.0": + # arc/orc have fatal bugs on 1.4 + if p.gc >= arc: + result = false + else: + discard var cores = corePhore()