From 9e2972940370c8bc5435fd5303dbe6a063e1f2db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Guitaut?= Date: Wed, 6 Mar 2024 12:22:47 +0100 Subject: [PATCH] DEV: Fix new Rubocop offenses --- Gemfile.lock | 37 ++++++++++++++++--- spec/lib/openid_connect_authenticator_spec.rb | 2 +- spec/requests/rp_initiated_logout_spec.rb | 2 +- 3 files changed, 33 insertions(+), 8 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 2b8cf11..24b6966 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,11 +1,31 @@ GEM remote: https://rubygems.org/ specs: + activesupport (7.1.3.2) + base64 + bigdecimal + concurrent-ruby (~> 1.0, >= 1.0.2) + connection_pool (>= 2.2.5) + drb + i18n (>= 1.6, < 2) + minitest (>= 5.1) + mutex_m + tzinfo (~> 2.0) ast (2.4.2) + base64 (0.2.0) + bigdecimal (3.1.6) + concurrent-ruby (1.2.3) + connection_pool (2.4.1) + drb (2.2.1) + i18n (1.14.3) + concurrent-ruby (~> 1.0) + racc (~> 1.7) json (2.7.1) language_server-protocol (3.17.0.3) + minitest (5.22.2) + mutex_m (0.2.0) parallel (1.24.0) - parser (3.3.0.4) + parser (3.3.0.5) ast (~> 2.4.1) racc prettier_print (1.2.1) @@ -14,7 +34,7 @@ GEM regexp_parser (2.9.0) rexml (3.2.8) strscan (>= 3.0.9) - rubocop (1.60.0) + rubocop (1.61.0) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) @@ -25,16 +45,19 @@ GEM rubocop-ast (>= 1.30.0, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 3.0) - rubocop-ast (1.30.0) - parser (>= 3.2.1.0) + rubocop-ast (1.31.1) + parser (>= 3.3.0.4) rubocop-capybara (2.20.0) rubocop (~> 1.41) - rubocop-discourse (3.6.0) + rubocop-discourse (3.7.1) + activesupport (>= 6.1) rubocop (>= 1.59.0) + rubocop-capybara (>= 2.0.0) + rubocop-factory_bot (>= 2.0.0) rubocop-rspec (>= 2.25.0) rubocop-factory_bot (2.25.1) rubocop (~> 1.41) - rubocop-rspec (2.26.1) + rubocop-rspec (2.27.1) rubocop (~> 1.40) rubocop-capybara (~> 2.17) rubocop-factory_bot (~> 2.22) @@ -42,6 +65,8 @@ GEM strscan (3.1.0) syntax_tree (6.2.0) prettier_print (>= 1.2.0) + tzinfo (2.0.6) + concurrent-ruby (~> 1.0) unicode-display_width (2.5.0) PLATFORMS diff --git a/spec/lib/openid_connect_authenticator_spec.rb b/spec/lib/openid_connect_authenticator_spec.rb index 495326f..28d06cf 100644 --- a/spec/lib/openid_connect_authenticator_spec.rb +++ b/spec/lib/openid_connect_authenticator_spec.rb @@ -5,7 +5,7 @@ describe OpenIDConnectAuthenticator do let(:authenticator) { described_class.new } - fab!(:user) { Fabricate(:user) } + fab!(:user) let(:hash) do OmniAuth::AuthHash.new( provider: "oidc", diff --git a/spec/requests/rp_initiated_logout_spec.rb b/spec/requests/rp_initiated_logout_spec.rb index 544f7be..de935cd 100644 --- a/spec/requests/rp_initiated_logout_spec.rb +++ b/spec/requests/rp_initiated_logout_spec.rb @@ -16,7 +16,7 @@ end_session_endpoint: "https://id.example.com/endsession", } end - fab!(:user) { Fabricate(:user) } + fab!(:user) before do SiteSetting.openid_connect_enabled = true