Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retina display support #85

Open
Neelfyn opened this issue Oct 15, 2012 · 6 comments · May be fixed by #293
Open

Retina display support #85

Neelfyn opened this issue Oct 15, 2012 · 6 comments · May be fixed by #293
Assignees

Comments

@Neelfyn
Copy link

Neelfyn commented Oct 15, 2012

Difference between Retina and non-Retina icons

It would be neat if the toolbar icon in Safari had a higher resolution for HiDPI displays.

See Safari Extensions Development Guide for reference.

@ghost ghost assigned dankwonjr Oct 15, 2012
@dgarzon
Copy link

dgarzon commented Nov 23, 2012

I agree I love Disconnect, but the non-retina button and icons look bad on the new MacBooks. Can you guys put some @2x image files to fix this? Thank you.

@harleydthomas
Copy link

Agreed. Would also love this on Chrome.

@mathiasbynens
Copy link

Looks like high-resolution versions of the icon are already part of the repository: https://github.com/disconnectme/disconnect/blob/master/firefox/content/disconnect.safariextension/opera/chrome/images/128.png So what’s the hold-up here? cc @byoogle

@Neelfyn
Copy link
Author

Neelfyn commented Apr 2, 2014

The new icon is actually high-resolution now, however the rest of the images in the menu aren't, but I'm guessing the priority for that is even lower. :)

Disconnect Retina icon

@mathiasbynens
Copy link

@Neelfyn Not in Opera and Chrome. Let’s create a separate issue for the in-menu icons :)

@Neelfyn
Copy link
Author

Neelfyn commented Apr 2, 2014

Ah, sorry, I had Safari in mind when I created the bug report, haven't tested it in another browser!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants