Provide sort_warnings_by attribute to sort warnings
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InderKumarRathore
force-pushed
the
sorted-warnings-new
branch
2 times, most recently
from
4e6b594
to
96bc409
Compare
|
@diogot did you get chance to review it. |
|
Hi @InderKumarRathore, can you rebase and update? I'll merge it once the tests pass. |
Signed-off-by: Inder <[email protected]>
InderKumarRathore
force-pushed
the
sorted-warnings-new
branch
from
96bc409
to
7928a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In our code base we keep on deprecating the APIs and because of that the warning result is huge. And with GitHub's max issue comment size we can't see all the warnings and it's hard to find non deprecated warnings in the code with that huge list of warnings. Thus we miss important warning because of deprecated ones.
Solution
Provide a
sort_warnings_byblock that sorts the warnings, and with the help of this we can keep important warnings on top and less important warnings at the bottom