Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not appending:false by default? #74

Open
guizoxxv opened this issue Oct 2, 2017 · 0 comments
Open

Why not appending:false by default? #74

guizoxxv opened this issue Oct 2, 2017 · 0 comments

Comments

@guizoxxv
Copy link

guizoxxv commented Oct 2, 2017

I had a problem with bpopup because my click event only opened a modal on the first time. Here is the problem:

I'm using jquery next() method to select the next sibling with class of 'modal' and open as modal window but by default the modal element was being removed from it's current DOM position and appended to body when opened. So there was no next sibling with class of modal after the first click. The solution was to change the bpopup 'appending' option to false.

I understand why the appending option is useful but I don't get why the default behavior is to append to body. For me it makes more sense for the modal to open where it is by default.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant