Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bevy 0.11 - fix compile errors #540

Merged
merged 11 commits into from
Nov 4, 2023

Conversation

johnny-smitherson
Copy link
Contributor

@johnny-smitherson johnny-smitherson commented Oct 23, 2023

see issue #541

compiles then panics

feel free to take over the upgrade, i usually only login on weekends

}

let vertex_buffer_layout = layout.get_layout(&[
Mesh::ATTRIBUTE_POSITION.at_shader_location(0),
Mesh::ATTRIBUTE_COLOR.at_shader_location(1),
])?;
let (label, blend, depth_write_enabled);
if key.contains(MeshPipelineKey::TRANSPARENT_MAIN_PASS) {
if key.contains(MeshPipelineKey::BLEND_ALPHA) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct? i don't know how this system works or what the enums mean. this is also not mentioned in the bevy upgrade notes 0.9-0.10-0.11

@Ughuuu
Copy link
Contributor

Ughuuu commented Nov 3, 2023

So does this fix the testbed examples to not freeze also? What is holding it back from getting merged?

@Ughuuu
Copy link
Contributor

Ughuuu commented Nov 3, 2023

Tried it and it does fix the testbed. Nice. Hope it gets merged soon. Right now seems the build is failing because of some unused variables.

@johnny-smitherson
Copy link
Contributor Author

ah, unused warnings - i can fix those sure thing

@sebcrozet thanks for the push - I didn't connect the new Gizmos API being the replacement for Debug Lines, even through I used both

@johnny-smitherson
Copy link
Contributor Author

johnny-smitherson commented Nov 3, 2023

  • I changed the version from 0.17 to 0.18 in some build files to verify in my external app that I run the modified version; if needed can remove those
  • I found a bug in the 3D variant about mouse selecting/picking of model

Red X is where the mouse is hovered, actual brick highlighted is flipped for mouse Y coord, mouse X coord is OK.

EDIT: bug does not happen on master branch

mouse1Capture mouse2Capture

@sebcrozet sebcrozet merged commit e9ea2ca into dimforge:master Nov 4, 2023
5 checks passed
@sebcrozet
Copy link
Member

Thanks @johnny-smitherson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants