Use the absolute value of the up attribute when calculating up_extent and side_extent #529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dimforge/bevy_rapier#413
I think that we should use the absolute value of the
up
attribute of aKinematicCharacterController
when calculating the value of theup_extent
andside_extent
variables.Concerning the
up_extent
variable, if you make theup
attribute point downward, parry will make the app crash because of theassert
in theloosened
function of theAABB
struct since the amount of loosening would be negative.And concerning the
side_extent
variable, the value would not be the same if theup
attribute points upward or downward.