Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the absolute value of the up attribute when calculating up_extent and side_extent #529

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

Linentio
Copy link
Contributor

Fixes dimforge/bevy_rapier#413

I think that we should use the absolute value of the up attribute of a KinematicCharacterController when calculating the value of the up_extent and side_extent variables.
Concerning the up_extent variable, if you make the up attribute point downward, parry will make the app crash because of the assert in the loosened function of the AABB struct since the amount of loosening would be negative.
And concerning the side_extent variable, the value would not be the same if the up attribute points upward or downward.

@sebcrozet sebcrozet merged commit 82416e3 into dimforge:master Oct 1, 2023
5 checks passed
@sebcrozet
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KinematicCharcaterController: the up vector cannot point downward
2 participants