-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace type alias with a 'use'. #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find, thanks!
We should consider doing that for the other aliases, e.g. use na::Vector3 as Vector
instead of type Vector<N> = Vector3<N>
(can be in a separate PR).
+1 for adding a changelog line.
|
9e37ca7
to
06364df
Compare
This adds a warning when running
Interestingly, this first one seems a good warning, we probably want
|
For the other, you could try |
Fixes #222