Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
try_normalize
,simd_try_normalize
compares the normn
againstmin_norm
. The former properly allows a value if it is greater than the minimum:nalgebra/src/base/norm.rs
Lines 397 to 401 in a3c2610
The simd version uses this comparison boolean as a lanewise mask, but the logic is currently inverted, such that a valid value greater than
min_norm
results in afalse
mask.