Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rapier context as a Component #545
Rapier context as a Component #545
Changes from 23 commits
d4ff57e
3cb7676
a01395e
4e7c36c
4952ea5
7a4ba5e
24fd036
f900dac
d171fe4
8dd49ee
2b262ea
f849cd2
df3578e
ac16f38
941b52e
5669a8c
0b9ca86
f4643ef
f8b296a
0e46610
75c2195
ccd2be7
9142888
ba0cd76
6d10fe6
d0b07a0
2676c35
40be1f1
deb0a06
cf165bd
aeab8c9
07eefbb
4cccde1
cbfe138
5dc5b2d
d0961d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a suggestion. Bevy has these
Read<>
andWrite<>
structs. Perhaps, to make the API look more idiomatic the access structs could be named as follow?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR: ok :)
I tend to prefer suffixes to prefix, so when you're searching for a term, the alphabetical order comes better grouped.
That said, my initial naming does a bad job at putting
Default
first. For this reason, I might prefer aRapierContextDefaultRead
; but that would probably mean renamingDefaultRapierContext
toRapierContextDefault
, which might sound weird.For the idiomatic way, I wanted to keep close to
Res
/ResMut
, which is very idiomatic. I believeRead
/Write
is used for individual components, which is not exaclty the case here. I'm not sure I've seen it inSystemParam
. But I'm not sure.In any way, I don't feel too opinionated about that, so I'll just implement your suggestion 😅.