Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InnerSpace Angle Implementation Bug #97

Open
shuyangsun opened this issue May 2, 2020 · 0 comments
Open

InnerSpace Angle Implementation Bug #97

shuyangsun opened this issue May 2, 2020 · 0 comments

Comments

@shuyangsun
Copy link

The implementation of angle function on trait InnerSpace is incorrect. When calculating cang, instead of multiplying the inner product by the norms of two vectors, it should be dividing them.

The correct calculation should be let cang = prod.real().unscale(n1 * n2);.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shuyangsun