Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bugs in CSS minifying #16

Open
ovflowd opened this issue Dec 27, 2016 · 8 comments
Open

Some bugs in CSS minifying #16

ovflowd opened this issue Dec 27, 2016 · 8 comments

Comments

@ovflowd
Copy link

ovflowd commented Dec 27, 2016

I saw that the script minifies CSS also, but has some bugs.
If the word 0 is found, removes all postfixes added on it.

(Like removing the % of 0%, since in CSS 0% = 0)

But this makes 0s became 0 in Transitions and also transforms 0% from transitions in 0. (That creates bugs in the syntax)

Why not using CSSMINIFY package? Like Explained in #13

@digitalsparky
Copy link
Owner

Hi sant0ro, the packag eis using the cssminify package as of v0.0.7.
Unfortunately the cssminify package appears to be no longer supported, I'll try and find a valid alternative.

@digitalsparky
Copy link
Owner

I've forked a pull request to the original cssminify package and rolled that package out as cssminify2, then updated jekyll-minifier to use cssminify2, this issue should now be resolved.

@ovflowd
Copy link
Author

ovflowd commented Dec 31, 2016

Thanks @digitalsparky !

@ovflowd
Copy link
Author

ovflowd commented Dec 31, 2016

It's seems that sadly the bugs continues. The CSSMinify continues removing the postfixes (from 0 absolute values).. and this bug transitions and animations.

@simonkurka
Copy link

@digitalsparky I can confirm: issue not resolved.

@digitalsparky digitalsparky reopened this Nov 3, 2018
@lsli8888
Copy link

Unfortunately, I'm still seeing this issue as well in 0.1.10.

@digitalsparky
Copy link
Owner

Sorry all, I've had a bit of a nightmare last few years and haven't really been able to do much. (I was in a car crash (not at fault) which caused a spinal injury.) I've been both in copious amounts of pain and also a pain killer induced zombie-mode... I'll get to this when I have some more capacity for concentration.

If anyone would like to help with this, please feel free to reach out.

Matt

@myst729
Copy link

myst729 commented Aug 20, 2022

@digitalsparky Wish you get better soon.

I also run into this issue, but a work-around DOES exist. For those who still suffer this issue, the answer is initial or unset keyword. Since transition-duration is not inheritable, both will reset the property to its initial value —0s.

transition-duration: initial;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants