Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat cmd/pokemon.go #31

Closed
digitalghost-dev opened this issue Aug 29, 2024 · 0 comments · Fixed by #33
Closed

Reformat cmd/pokemon.go #31

digitalghost-dev opened this issue Aug 29, 2024 · 0 comments · Fixed by #33
Labels
refactor Refactoring existing code.

Comments

@digitalghost-dev
Copy link
Owner

Several improvements can be made to this file:

  • Declaring the lipgloss variables as global since two functions are using them.
  • Move if args[2] == "-h" || args[2] == "--help" {} statement to the ValidateArgs() function.
  • Better format error messages to be included in a red rounded-border with the error message in normal color.
Repository owner deleted a comment Aug 29, 2024
@digitalghost-dev digitalghost-dev added the improvement Improvement to an existing feature. label Sep 5, 2024
@digitalghost-dev digitalghost-dev linked a pull request Sep 11, 2024 that will close this issue
0.5.1 #33
Merged
@digitalghost-dev digitalghost-dev added refactor Refactoring existing code. and removed improvement Improvement to an existing feature. labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactoring existing code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

0.5.1 digitalghost-dev/poke-cli
1 participant
@digitalghost-dev