Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "edit" icon to contacts #3187

Open
JoeyStk opened this issue Nov 7, 2024 · 2 comments · May be fixed by #3202
Open

Add "edit" icon to contacts #3187

JoeyStk opened this issue Nov 7, 2024 · 2 comments · May be fixed by #3202
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@JoeyStk
Copy link
Contributor

JoeyStk commented Nov 7, 2024

Describe the Bug

For pages, events and POIs we have an additional icon for editing. For contacts we don't have that yet. After UI/UX testing it was wished for sake of consistency to add the icon to contacts too

Steps to Reproduce

  1. Go to 'pages
  2. See icon "edit"
  3. Go to 'contact'
  4. See it's not there

Expected Behavior

Consistency between the content types

Actual Behavior

Icon missing for contacts

Additional Information

None

@JoeyStk JoeyStk added the bug Something isn't working label Nov 7, 2024
@MizukiTemma
Copy link
Member

@JoeyStk
Do you mean the pensil icon in the column "Options" in the page/POI/event/contact list? It exists only in the page tree if nothing is missing in my environment. Do we introduce it in all the list views?

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Nov 7, 2024

Yes, I mean the pencil. I assume that we would introduce it to all list views, but this is probably a question for @nikolahoff :)

@MizukiTemma MizukiTemma added the good first issue Good for newcomers label Nov 7, 2024
@JoeyStk JoeyStk linked a pull request Nov 12, 2024 that will close this issue
@JoeyStk JoeyStk added this to the 24Q4 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants