Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if release date has changed on existing release #70

Open
sunradiofree opened this issue Jul 15, 2022 · 8 comments
Open

Check if release date has changed on existing release #70

sunradiofree opened this issue Jul 15, 2022 · 8 comments
Assignees
Labels
bug Something isn't working investigating

Comments

@sunradiofree
Copy link

When release date is in the future and some track have been availabled before, deemon thinks it has already download the full album. Perhaps, it has only downloaded the available tracks at moment of the download. When the release date is reach, nothing append, so it looses the other tracks.

@sunradiofree sunradiofree changed the title Missing albums file when release date is future Missing album files when release date is future Jul 15, 2022
@sunradiofree sunradiofree changed the title Missing album files when release date is future Missing album files when release date that was in the future is reach Jul 15, 2022
@sunradiofree
Copy link
Author

In my case the realease_id was registered in database as "2021-01-01". So I think it was not seed as "future release".
Moreover, with id 334190677 it could not be released in "2021-01-01". So hard to dectect ! Maybe logging releases with "not available tracks" and re-try to download them in the future?

@sunradiofree
Copy link
Author

Other id, checkin release date, and if release date is not the same than the one registered in database, re-download the album.

@digitalec
Copy link
Owner

I'll check into this but if the release date is not in the future, I have no other way of knowing if it's a future release.

Sometimes tracks are not available due to licensing so retrying on every refresh would cause that album to always fail.

@sunradiofree
Copy link
Author

I think this album (334190677) was first set up as "20210101" (because this is the release date registered in the db file) and today change to "20220715", with enabling all the tracks. That's why I suggest checking the release date when refreshing, so if the date change, re-downloading the release.
Of course I understand that retry each time not available tracks will always fail and is not a correct way.

@digitalec
Copy link
Owner

That may be possible. I already perform a check if the ID exists so I would expand that to if the ID and release date exist as a pair. I'm away for the next week but I'll implement this when I return. Good idea!

@digitalec digitalec changed the title Missing album files when release date that was in the future is reach Check if release date has changed on existing release Jul 15, 2022
@digitalec digitalec self-assigned this Jul 15, 2022
@digitalec digitalec added the feature New feature or request label Jul 15, 2022
@digitalec digitalec added this to the 3.0 milestone Jul 29, 2022
@digitalec digitalec added bug Something isn't working and removed feature New feature or request labels Aug 2, 2022
@digitalec digitalec modified the milestones: 3.0, 2.14.1 Aug 2, 2022
@sunradiofree
Copy link
Author

deemon
I set the right release date to the db and set future to "1". It downloads the album but it set again the release date to "2022-08-12", so it's not the same field for release date like in deemix. Detecting changes could not work because it doesn't change...

@digitalec
Copy link
Owner

Deezer has 3 different release dates: Original, Physical and Digital. I've experimented with the order in the past and found the current order to be the most accurate. I'll look into this particular case though to see how this could be resolved.

@digitalec digitalec removed this from the 2.14.1 milestone Oct 22, 2022
@sunradiofree
Copy link
Author

ok, but when some tracks are not availables, they will never be downloaded with deemon.this joins the subject of failed downloads.
https://www.deezer.com/album/366967207
https://www.deezer.com/album/364892387
At this moment this 2 albums have been tagged as "downloaded" in deemon but a lot of tracks were not available, and I need to manually wait the other release date and download them.Nevertheless, it's good to have as soon as possible availables tracks of a future release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigating
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants