Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http(feat): router as single source of truth #159

Open
axtho opened this issue Oct 28, 2017 · 2 comments
Open

http(feat): router as single source of truth #159

axtho opened this issue Oct 28, 2017 · 2 comments
Labels
discussion enhancement tricky
Milestone
Backlog

Comments

@axtho
Copy link
Contributor

axtho commented Oct 28, 2017

make the router the single source of truth (e.g. rehydrate): this requires to set ROUTER_NAVIGATION events for each of the modules, i.e. so we don't dispatch actions in constructor or OnInit, but rather check and react to router changes. This way we also have less issues with browser refreshes

See: https://github.com/vsavkin/state_management_ngrx4/blob/master/clientapp/src/app/model.ts
@axtho axtho added this to the Backlog milestone Oct 28, 2017
@axtho
Copy link
Contributor Author

axtho commented Nov 22, 2017

not sure this is even possible/ feasable...

@axtho
Copy link
Contributor Author

axtho commented Mar 7, 2018

now it is possible, if we rewrite the effects classes to use the nx supplied strategies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement tricky
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@axtho