Add support for compressing arbitrary URLs. #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlehn
force-pushed
the
app-url-codec
branch
2 times, most recently
from
29bf4e1
to
ce06067
Compare
dlongley
requested changes
Dec 21, 2023
| [1025, Base58DidUrlDecoder] | ||
| [1025, Base58DidUrlDecoder], | ||
| // FIXME: encdeds as 3 bytes, may want to use a lower id | ||
| [1026, AppUrlDecoder] |
There was a problem hiding this comment.
Seems like we could use 4 here without issue, right?
There was a problem hiding this comment.
I'm not sure what the policy is here. This is another registry of ids. This app url codec seems general enough to use a limited low id. Perhaps more specialized codecs don't? I'm guessing that's why the base58did ones are higher?
|
|
||
| ### Added | ||
| - Add support for compressing arbitrary URLs. Any id which is in the | ||
| `appContextMap` will be compressed as a single number before using other URL |
There was a problem hiding this comment.
We should add an alias for appContextMap and start using it -- and deprecate the name appContextMap and remove it in the next version.
Maybe appTermMap, appTermIdMap, or appStringMap ... open to alternatives.
Add support for compressing arbitrary URLs. Any id which is in the `appContextMap` will be compressed as a single number before using other URL codecs.
davidlehn
force-pushed
the
app-url-codec
branch
from
ce06067
to
38ba50e
Compare
|
I'm closing this because PR #87 supersedes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for compressing arbitrary URLs. Any id which is in the
appContextMapwill be compressed as a single number before using other URL codecs.appContextMapnaming is being overridden here and elsewhere. This feature could change and use another map.1026is encoded as 3 bytes. A low value would be 1 or 2 bytes. If lots of URLs get encoded this would add up.