Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial #1

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Initial #1

wants to merge 46 commits into from

Conversation

aljones15
Copy link

@aljones15 aljones15 commented Aug 18, 2023 •
edited
Loading

This is a PR with a lot of functionality in it:

  1. Adds a README with a large amount of entries
  2. Adds a script for creating an initial capacitor.config.json
  3. Adds a script for setting App manifests to allow WebView, ServiceWorker, and iframe support.
  4. Android Service Worker support

@aljones15
Add gitiginore.
a002fae
@aljones15
Add package.json.
9abd26c
@aljones15
add bedrock LICENSE.
e56f763
@aljones15
Add initial README and CHANGELOG.
b42bd83
@aljones15
Ignore capacitor config & app initial setup scripts.
3713c5f
@aljones15
Write config files direct to ios and android projects.
892308f
@aljones15
Change project name to com.digitalbazaar.native.
e2e1d4d
@aljones15
Add initial entry in CHANGELOG.
bd14ff3
@aljones15
Further paramertize manifest creation script.
88e939f
@aljones15
Add set-app-manifests to package.json.
376375f
@aljones15
Add instructions for native-app-config, source it, & ignore it.
5717dc3
@aljones15
PATCH: missing closing " in package.json.
ec17f95
@aljones15
Move capacitor config creation script to separate file.
0fba162
@aljones15
Add create-capacitor-config command to package.json.
d8037ef
@aljones15
Move scripts to scripts dir.
a1f1e4c
@aljones15
Ignore files in www dir.
76c0bb2
@aljones15
Add www dir required by capacitor.
5aeb7c2
@aljones15
Add Android plugin with allow Service Workers.
2e2e06b
@aljones15
PATCH: correct missing comma in package.json.
82384a3
@aljones15
Add README Setup section on Deep Links.
46eaa71
@aljones15
Remove Android Service Worker files in favor of a creation script.
41b7af1
@aljones15
Use name bedrock-native-app in README and package.json.
17df815
@aljones15
Improve README with better quotes, diction, & fewer typos.
7082f0d
@aljones15
Add Capacitor iOS Setup & required vs optional.
b626e43
@aljones15
Remove references to you from README & add set-build-env to package.j…
17fbf4f 
…son scripts.
@aljones15
Turn Deep Links links into a list.
a9a1bbe
@aljones15 aljones15 self-assigned this Aug 18, 2023
davidlehn
davidlehn reviewed Oct 31, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 41 to 50
If brew fails to install:

```sh
sudo rm -rf /opt/homebrew
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/uninstall.sh)"
```
then try to install again



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems out-of-scope. Can it link to brew instructions, or just be removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review. I removed this here and just linked to the brew homepage: 47b0d17

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
aljones15 and others added 9 commits October 31, 2023 11:43
@aljones15 @davidlehn
Update README.md Capitalize MacOS.
fa5f3bc 
Co-authored-by: David I. Lehn <[email protected]>
@aljones15 @davidlehn
Update README.md avoid using here in favor of direct link to official…
d97d30b 
… platforms.

Co-authored-by: David I. Lehn <[email protected]>
@aljones15 @davidlehn
Update README.md correct link in Android section to iOS instructions.
d2e39f8 
Co-authored-by: David I. Lehn <[email protected]>
@aljones15 @davidlehn
Update README.md avoid using here in favor of direct links to Cap App…
33f29c6 
… Link docs.

Co-authored-by: David I. Lehn <[email protected]>
@aljones15 @davidlehn
Update README.md links to capacitor assests.
4e32fb1 
Co-authored-by: David I. Lehn <[email protected]>
@aljones15 @davidlehn
Update README.md clarify generate-app-icons command.
c97c6f8 
Co-authored-by: David I. Lehn <[email protected]>
@aljones15 @davidlehn
Update README.md link ios to env setup over homebrew.
911f60a 
Co-authored-by: David I. Lehn <[email protected]>
@aljones15
Remove brew trouble shooting & add links to Brew and Cocoapods.
47b0d17
@aljones15
Correct typo in README libraries to library.
9168a26
@aljones15 aljones15 marked this pull request as ready for review October 31, 2023 17:11
@aljones15 aljones15 requested a review from tminard May 31, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlehn davidlehn Awaiting requested review from davidlehn

@tminard tminard Awaiting requested review from tminard

At least 1 approving review is required to merge this pull request.

Assignees

@aljones15 aljones15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljones15 @davidlehn