Feat/vec 35 allow vector app to work #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urastogi885
reviewed
Apr 29, 2022
internal/voice/stream/connect.go
Outdated
| @@ -59,7 +59,7 @@ func (strm *Streamer) newChipperConn(ctx context.Context) (Conn, *CloudError) { | |||
| }, | |||
| } | |||
|
|
|||
| otaURL = "https://" + config.Env.Check + suffix | |||
| otaURL = "http://" + config.Env.Check + suffix | |||
There was a problem hiding this comment.
I don't think we need this anymore.
With the 1.8 escape pod update, escape pod runs fake https so Vector can at least send HTTPS GET request to escape pod.
The additions to makefile and readme might still be useful.
vural4646
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the broken link to do a chipper connection test. Allowing the Vector app to work with Vectors on escape-pod stack