Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: guidelines for accordion #835

Merged
merged 14 commits into from
Sep 28, 2023
Merged

docs: guidelines for accordion #835

merged 14 commits into from
Sep 28, 2023

Conversation

mrosvik
Copy link
Member

@mrosvik mrosvik commented Sep 19, 2023

No description provided.

@mrosvik mrosvik marked this pull request as ready for review September 19, 2023 21:19
@mrosvik
Copy link
Member Author

mrosvik commented Sep 19, 2023

@Thuneer @mimarz Hva tenker dere om Props for Item, Header og Content? Bør det ligger øverst sammen med de andre Propsene, eller nederst?

@mrosvik mrosvik added the 📔 storybook storybook.designsystemet.no label Sep 20, 2023
@mrosvik mrosvik marked this pull request as draft September 20, 2023 08:12
@mrosvik mrosvik marked this pull request as ready for review September 20, 2023 08:12
@github-actions
Copy link
Contributor

Storybook preview deployment is available at https://storybook-igzrf2ene-designsystemet.vercel.app

@mrosvik mrosvik marked this pull request as draft September 20, 2023 20:27
@mrosvik
Copy link
Member Author

mrosvik commented Sep 20, 2023

@mimarz Kan du skrive noe om Kontrollert-eksempelet? Og skulle det ikke egentlig vært vist på en annen måte, med f.eks en knapp over som åpner alle?

@mimarz
Copy link
Collaborator

mimarz commented Sep 21, 2023

@mimarz Kan du skrive noe om Kontrollert-eksempelet? Og skulle det ikke egentlig vært vist på en annen måte, med f.eks en knapp over som åpner alle?

Jeg har oppdatert eksempelet @mrosvik

@mimarz mimarz marked this pull request as ready for review September 21, 2023 06:40
@github-actions
Copy link
Contributor

Storybook preview deployment is available at https://storybook-i7ghz9ehm-designsystemet.vercel.app

TomasEng
TomasEng approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg synes dette ser bra ut. La til noen forslag til ørsmå tekstutbedringer.

packages/react/src/components/Accordion/Accordion.mdx Outdated Show resolved Hide resolved
packages/react/src/components/Accordion/Accordion.stories.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Accordion/Accordion.stories.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Accordion/Accordion.stories.tsx Outdated Show resolved Hide resolved
@mimarz mimarz merged commit 86e79e6 into main Sep 28, 2023
2 checks passed
@mimarz mimarz deleted the docs/guidelines-accordion branch September 28, 2023 07:24
Barsnes pushed a commit that referenced this pull request Sep 28, 2023
@mrosvik @mimarz
@TomasEng @Barsnes
docs: guidelines for accordion (#835)
f84377d 
Co-authored-by: Michael Marszalek <[email protected]>
Co-authored-by: Tomas Engebretsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasEng TomasEng TomasEng approved these changes

@mimarz mimarz Awaiting requested review from mimarz mimarz is a code owner

@Thunear Thunear Awaiting requested review from Thunear

@framitdavid framitdavid Awaiting requested review from framitdavid

@Magnusrm Magnusrm Awaiting requested review from Magnusrm

Assignees
No one assigned
Labels
📔 storybook storybook.designsystemet.no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrosvik @mimarz @TomasEng