Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: Decide on responsive approach and worst case scenarios #916

Open
Tracked by #1045
mimarz opened this issue Oct 9, 2023 · 7 comments
Open
Tracked by #1045

Tabs: Decide on responsive approach and worst case scenarios #916

mimarz opened this issue Oct 9, 2023 · 7 comments
Labels
🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react

Comments

@mimarz
Copy link
Collaborator

mimarz commented Oct 9, 2023

We need to decide on how we should resolve the following use-case, and update code & guidelines in accordance.

  • What are our recommendations for mobile?
  • To long tab titles making tabs go outside viewport?
@mimarz mimarz converted this from a draft issue Oct 9, 2023
@mimarz mimarz added 🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react documentation/guidelines For documentation related to guidelines labels Oct 9, 2023
@TheTechArch
Copy link
Contributor

TheTechArch commented Oct 9, 2023

Add this as example. 4 options go out of viewport. Example from here
image

@Barsnes
Copy link
Member

Barsnes commented Oct 9, 2023

I think there are a couple options, each with their own tradeoff. Personally I like scrollable tabs, which is probably the easiest solution, but it needs to communicate that you can scroll, either with an arrow or scrollbar. Maybe this could be coupled with a prop to only display the icon on mobile?
Other options would be change to dropdown or to stack them.

@mimarz
Copy link
Collaborator Author

mimarz commented Oct 31, 2023

Meeting 31.10.23

We decided we should implement horizontal overflow with scroll and button navigation.

Example: https://storybook.eds.equinor.com/?path=/docs/navigation-tabs--docs#overflow-with-nextprevious-buttons

@mimarz mimarz moved this from 📋 Backlog to 📄 Todo in Team Design System Oct 31, 2023
@mrosvik mrosvik added this to the 4. Lansere versjon 1.0.0 milestone Feb 1, 2024
@mrosvik mrosvik removed this from the 4. Lansere versjon 1.0.0 milestone Apr 23, 2024
@mrosvik mrosvik removed the documentation/guidelines For documentation related to guidelines label Jun 24, 2024
@simon-archer
Copy link

Hey! Based on the previous comment, by @mimarz, is this issue resolved? Or anything else that should be considered in issue #1491 and #2449 that is not mentioned here?

@mimarz
Copy link
Collaborator Author

mimarz commented Dec 12, 2024

This has not been solved yet. We never got around to implementing previous comment. We'll make sure to find an answer to this before v1 tho.

@simon-archer
Copy link

This has not been solved yet. We never got around to implementing previous comment. We'll make sure to find an answer to this before v1 tho.

I'll be happy to try to find an answer and mark this as solved. Please let me know if there is anything specific that is blocking us from figuring this out :) The Equinor example seems to be a good solution for V1 at least.

I'm working on an updated version of the current Storybook documentation of the Tabs component at the moment.

@mrosvik
Copy link
Member

mrosvik commented Dec 13, 2024

Horizontal overflow with CSS should be fixed before V1. The buttons could come later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react
Projects
Status: 📄 Todo
Development

No branches or pull requests

5 participants