Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ErrorMessage size large #837

Closed
mimarz opened this issue Sep 20, 2023 · 5 comments
Closed

Add missing ErrorMessage size large #837

mimarz opened this issue Sep 20, 2023 · 5 comments
Labels
🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme

Comments

@mimarz
Copy link
Collaborator

mimarz commented Sep 20, 2023 •
edited
Loading

After examining components that are used together we identified that ErrorMessage is missing a size Large to pair with other form text options.

This will need to be added to Figma, tokens and React.
@mimarz mimarz converted this from a draft issue Sep 20, 2023
@mimarz mimarz added 🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme labels Sep 20, 2023
@mimarz
Copy link
Collaborator Author

mimarz commented Sep 20, 2023

Could one of you guys add this soon-ish? @mrosvik @Febakke ErrorMessage currently defaults to medium size when large is selected for the new Textfield.

@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Sep 20, 2023
@mrosvik
Copy link
Member

mrosvik commented Sep 20, 2023

yup.

@mrosvik
Copy link
Member

mrosvik commented Sep 20, 2023

#839

@mimarz
Copy link
Collaborator Author

mimarz commented Oct 6, 2023

Is this added in Figma? @mrosvik @Febakke

@Febakke
Copy link
Member

Febakke commented Oct 6, 2023

Seems like it is: https://www.figma.com/file/vpM9dqqQPHqU6ogfKp5tlr/Felles-komponenter?type=design&node-id=20750%3A76353&mode=design&t=t24ZXTXKIWpqxnad-1

@mrosvik mrosvik closed this as completed Oct 6, 2023
@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Design System Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme
Projects
Team Design System
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mimarz @mrosvik @Febakke