Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma file defaults to wrong border-radius when using wrong custom theme #2861

Closed
mimarz opened this issue Dec 5, 2024 · 2 comments
Closed
Assignees
Labels
🐛 bug Something isn't working 🎨 figma Everything related to changes in Figma

Comments

@mimarz
Copy link
Collaborator

mimarz commented Dec 5, 2024

Bug filed from user in DM on slack.

Tested together via teams.

When using custom theme: https://next.theme.designsystemet.no/?accent=%231d5f4a&brand1=%233a8a79&brand2=%23d9771a&brand3=%238a4f8d&theme=light&neutral=%234d4d4d

Bug:
Using github and Token Studio, after syncing in Figma, border-radius-default is referenced to border-radius-full instead of border-radius-4

Notes:

  • design-tokens json had the correct references so something with how sync settings was used maybe?
@mimarz mimarz converted this from a draft issue Dec 5, 2024
@mimarz mimarz added 🐛 bug Something isn't working 🎨 figma Everything related to changes in Figma labels Dec 5, 2024
@mimarz
Copy link
Collaborator Author

mimarz commented Dec 9, 2024

We will test this again to try an reproduce. Suspect it has to do with different settings in Token Studio when exporting to Figma. Maybe the remove all variables without links?

@mimarz mimarz added this to the V1 - Helhetlig tematisering milestone Dec 9, 2024
@mimarz mimarz moved this from 🔵 Inbox to 🏗 In progress in Team Design System Dec 9, 2024
@Febakke
Copy link
Member

Febakke commented Dec 9, 2024

I was not able to recreate this. The variables and tokens are correctly referenced and im not sure how this is possible without something happening when exporting tokens to variables in Figma and a connection being broken at some point.

I think we should close this @mimarz

@mrosvik mrosvik closed this as completed Dec 11, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Team Design System Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🎨 figma Everything related to changes in Figma
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants