Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename design tokens group "Mode" to "Color scheme" #2799

Closed
Tracked by #2706
unekinn opened this issue Nov 20, 2024 · 0 comments · Fixed by #2808
Closed
Tracked by #2706

Rename design tokens group "Mode" to "Color scheme" #2799

unekinn opened this issue Nov 20, 2024 · 0 comments · Fixed by #2808
Labels
cli @digdir/designsystemet $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme

Comments

@unekinn
Copy link
Contributor

unekinn commented Nov 20, 2024

Related to #2706 - the name "Mode" and its folder structure primitives/modes/colors/<scheme> is confusing now that we have several other modes.

Suggetion:

  • "Mode" → "Color scheme"
  • primitives/modes/colors/<scheme> → primitives/modes/color-scheme/<scheme>
@unekinn unekinn added the $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme label Nov 20, 2024
@mimarz mimarz mentioned this issue Nov 20, 2024
Closed
unekinn added a commit that referenced this issue Nov 20, 2024
@unekinn
refactor(cli, design-tokens): rename "Mode" to "Color scheme" and `mo…
3984a51 
…des/colors` to `modes/color-scheme`

Closes #2799
unekinn added a commit that referenced this issue Nov 20, 2024
@unekinn
refactor(cli, design-tokens): rename "Mode" to "Color scheme" and `mo…
866eb86 
…des/colors` to `modes/color-scheme`

Closes #2799
@unekinn unekinn mentioned this issue Nov 20, 2024
Merged
unekinn added a commit that referenced this issue Nov 20, 2024
@unekinn
refactor(cli, design-tokens): rename "Mode" to "Color scheme" and `mo…
5100b08 
…des/colors` to `modes/color-scheme`

Closes #2799
unekinn added a commit that referenced this issue Nov 21, 2024
@unekinn
refactor(cli, design-tokens): rename "Mode" to "Color scheme" and `mo…
9b3c1ac 
…des/colors` to `modes/color-scheme`

Closes #2799
@unekinn unekinn added the cli @digdir/designsystemet label Nov 21, 2024
@github-project-automation github-project-automation bot moved this from 🔵 Inbox to ✅ Done in Team Design System Nov 21, 2024
@github-project-automation github-project-automation bot moved this from 🔵 Inbox to ✅ Done in Team Design System Nov 21, 2024
Barsnes added a commit that referenced this issue Nov 22, 2024
@unekinn @Barsnes
refactor: rename "Mode" to "Color scheme" and modes/colors to `mode…
9cf5841 
…s/color-scheme` (#2808)

Closes #2799

Co-authored-by: Tobias Barsnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli @digdir/designsystemet $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme
Projects
Team Design System
Status: ✅ Done
Milestone
No milestone
1 participant
@unekinn