Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike nx for monorepo managment #2776

Open
mimarz opened this issue Nov 13, 2024 · 0 comments
Open

Spike nx for monorepo managment #2776

mimarz opened this issue Nov 13, 2024 · 0 comments
Labels
🕵️ investigate Needs investigation ⚙️ technical Technical improvements, maintenance or other issues that are not directly linked to a feature

Comments

@mimarz
Copy link
Collaborator

mimarz commented Nov 13, 2024

Spike on using nx for managing our monorepo.

We have more and more apps & libraries that are depandant on eachother that needs to be rebuilt or typecheck when changes are made. Having some parts cached might also help for CI runs on PRs.

In the future we might want to also have some test apps for generic vite/nextjs/webpack project.

This will add more complexity and dependencies to our project but the benefit of catching errors might out weigh this if its easy and fast to setup and use.

@mimarz mimarz added ⚙️ technical Technical improvements, maintenance or other issues that are not directly linked to a feature 🕵️ investigate Needs investigation labels Nov 13, 2024
@mimarz mimarz moved this to 🔵 Inbox in Team Design System Nov 13, 2024
@mimarz mimarz changed the title Spike nx for monorepo managment Spike nx for monorepo managment Nov 13, 2024
@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Dec 9, 2024
mimarz added a commit that referenced this issue Dec 12, 2024
A simple way to type checking all our projects now without relying on
third party for now., until we have a look at #2776

- run `yarn types` to run this check locally
- Checks gh action is noticeably slower now with runtime going for 50s
to 1min 20s. I think we are ok with this for now since we have other
stuff running longer on PRs.
- Using [yarn workspaces
foreach](https://yarnpkg.com/cli/workspaces/foreach) we run `types`
script on all our packages that have it defined.
- Fixed a couple of linting errors and mistakes deleting stuff that was
used
- Added `types` script on relevant projects


Current type checked projects
```
[@digdir/designsystemet]
[@digdir/designsystemet-react]
[@designsystemet/storybook]
[@repo/components]
[figma-plugin]
[storefront]
[theme]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕵️ investigate Needs investigation ⚙️ technical Technical improvements, maintenance or other issues that are not directly linked to a feature
Projects
Status: 📄 Todo
Development

No branches or pull requests

1 participant