Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Large does not behave the same way as Switch Medium and Small in Figma #2769

Closed
Viveca24 opened this issue Nov 11, 2024 · 2 comments
Closed
Labels
🎨 figma Everything related to changes in Figma

Comments

@Viveca24
Copy link
Contributor

Viveca24 commented Nov 11, 2024

The Switch Large component does not adjust the width of the description to match the length of the label, unlike Switch Medium and Switch Small. With Switch Medium and Switch Small, the description width dynamically adapts to the label length, but this does not occur for Switch Large. This issue affects only the left label option, not the right.

The Switch Large component’s description width should adapt to the length of the label in the same way as Switch Medium and Switch Small, ensuring consistent behavior across all switch sizes.

Steps to Reproduce:

  1. Use the switch component in Figma in small and large siize.
  2. Set the label position to "left."
  3. Add a label with varying lengths to each size. Add description as well.
  4. Observe the description width for each switch size.

Image

This issue also causes problems in our test file. When we detach instances, Switch Large appears visually different from the instances, with the description text breaking at an earlier point than expected. This inconsistency complicates visual testing and makes it harder to ensure uniformity across designs.

@Viveca24 Viveca24 converted this from a draft issue Nov 11, 2024
@Viveca24 Viveca24 added the 🎨 figma Everything related to changes in Figma label Nov 11, 2024
@Febakke
Copy link
Member

Febakke commented Nov 18, 2024

Should be fixed in Figma now.
Text element in description was set to fixed. Changed to hug

@mrosvik
Copy link
Member

mrosvik commented Nov 20, 2024

LGTM! :D

@mrosvik mrosvik closed this as completed Nov 20, 2024
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 figma Everything related to changes in Figma
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants