Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Paragraph long and short and consider wether this is component props at all #2445

Closed
eirikbacker opened this issue Sep 18, 2024 · 1 comment

Comments

@eirikbacker
Copy link
Contributor

Today we have Paragraph, Paragraph variant="short" and Paragraph variant="long".
This means our consumers can make any Paragraph component short or long.

I understand we need short and long in context of i.e. text inside a Card, but I'm unsure wether we want Paragraph component aka. body text to be varying in line height, breaking the typographic flow.
I suggest we make a distinction between what is a text style and what is a typography component.

Also, variant="long" and variant="short" is a bit confusing for me - may be personal opinion, but could density="compact" and density="loose" better? ☺

@eirikbacker eirikbacker converted this from a draft issue Sep 18, 2024
@mimarz
Copy link
Collaborator

mimarz commented Sep 24, 2024

replaced by 2503

@mimarz mimarz closed this as completed Sep 24, 2024
@github-project-automation github-project-automation bot moved this from 🔵 Inbox to ✅ Done in Team Design System Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants