Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio buttons: missing margin on error message when hidelegend is set to true #2406

Closed
frikkfelix opened this issue Sep 12, 2024 · 3 comments
Assignees
Labels
🐛 bug Something isn't working react @digdir/designsystemet-react

Comments

@frikkfelix
Copy link

Description of the bug

When hideLegend={true} on Radio.Group, there is no spacing between the radio buttons and the error message.

Steps To Reproduce

  1. Add a Radio.Group and set hideLegend to true
  2. Set error prop on Radio.Group

Additional Information

No response

@frikkfelix frikkfelix added the 🐛 bug Something isn't working label Sep 12, 2024
@mimarz mimarz added the react @digdir/designsystemet-react label Sep 13, 2024
@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Sep 13, 2024
@Barsnes
Copy link
Member

Barsnes commented Sep 16, 2024

Here is a direct link to a story showing that the error message does not have spacing above it.
https://next.storybook.designsystemet.no/?path=/story/komponenter-radio-group--preview&args=error:Ein+error;hideLegend:!true&globals=theme:Dark

I can't seem to reproduce it where the spacing is removed between radio buttons as well.

@mimarz
Copy link
Collaborator

mimarz commented Sep 18, 2024

We have planned a revision of CSS for Radio so we'll have a look at this when we do this.

@eirikbacker
Copy link
Contributor

Fixed by #2607

@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Design System Nov 1, 2024
@eirikbacker eirikbacker self-assigned this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working react @digdir/designsystemet-react
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants