Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Select.Option for consistent API #2403

Closed
eirikbacker opened this issue Sep 12, 2024 · 1 comment · Fixed by #2415
Closed

Create Select.Option for consistent API #2403

eirikbacker opened this issue Sep 12, 2024 · 1 comment · Fixed by #2415
Assignees
@eirikbacker
Labels
react @digdir/designsystemet-react

Comments

@eirikbacker
Copy link
Contributor

eirikbacker commented Sep 12, 2024 •
edited
Loading

We use native <option> in Select. We should add a Select.Option and Select.Optgroup to match our other components API (i.e. li is List.Item)
@eirikbacker eirikbacker converted this from a draft issue Sep 12, 2024
@eirikbacker eirikbacker self-assigned this Sep 12, 2024
@eirikbacker eirikbacker added the react @digdir/designsystemet-react label Sep 12, 2024
@eirikbacker
Copy link
Contributor Author

Related to #2221

@eirikbacker eirikbacker moved this from 📄 Todo to 🏗 In progress in Team Design System Sep 15, 2024
@eirikbacker eirikbacker mentioned this issue Sep 15, 2024
Merged
@eirikbacker eirikbacker moved this from 🏗 In progress to 👀 Ready for review in Team Design System Sep 15, 2024
eirikbacker added a commit that referenced this issue Sep 16, 2024
@eirikbacker @Barsnes
fix(Select): option and optgroup compond components (#2415)
7f0cc0d 
- Fixes #2403
- Also omits `multiple` parameter after talk with Lasse as this there is
no design for this, and the user experience is not very good

---------

Co-authored-by: Tobias Barsnes <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eirikbacker eirikbacker

Labels
react @digdir/designsystemet-react
Projects
Team Design System
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Select): option and optgroup compond components digdir/designsystemet
1 participant
@eirikbacker