Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NativeSelect to Select #2399

Closed
2 tasks done
mimarz opened this issue Sep 11, 2024 · 0 comments · Fixed by #2404
Closed
2 tasks done

Rename NativeSelect to Select #2399

mimarz opened this issue Sep 11, 2024 · 0 comments · Fixed by #2404
Assignees
@eirikbacker
Labels
documentation/code For documentation related to code and technical specifications react @digdir/designsystemet-react

Comments

@mimarz
Copy link
Collaborator

mimarz commented Sep 11, 2024 •
edited by eirikbacker
Loading

In an effort to simplify naming and have a clear connection to standard HTML, we decided to rename NativeSelect to Select.

Reasoning

  • It renders a <select>.
  • We dont use native naming for our other "native" components (such as Button).
  • For accessibility and mobile reasons, we want to promote and advise use of the native select element as a "select", instead of some third party library.

Tasks
Beta Give feedback
@mimarz mimarz converted this from a draft issue Sep 11, 2024
@mimarz mimarz added documentation/code For documentation related to code and technical specifications react @digdir/designsystemet-react labels Sep 11, 2024
@eirikbacker eirikbacker self-assigned this Sep 12, 2024
@eirikbacker eirikbacker moved this from 📄 Todo to 🏗 In progress in Team Design System Sep 12, 2024
@eirikbacker eirikbacker mentioned this issue Sep 12, 2024
Merged
@eirikbacker eirikbacker moved this from 🏗 In progress to 👀 Ready for review in Team Design System Sep 12, 2024
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eirikbacker eirikbacker

Labels
documentation/code For documentation related to code and technical specifications react @digdir/designsystemet-react
Projects
Team Design System
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Select): rename from nativeselect digdir/designsystemet
2 participants
@eirikbacker @mimarz