Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution for Pagination wrapping/zoom #2396

Open
eirikbacker opened this issue Sep 9, 2024 · 5 comments
Open

Solution for Pagination wrapping/zoom #2396

eirikbacker opened this issue Sep 9, 2024 · 5 comments
Labels
react @digdir/designsystemet-react

Comments

@eirikbacker
Copy link
Contributor

Pagination does not wrap when zoomed / too little space. We should decide on a good solution for this - maybe even an internal ResizeObserver?
@eirikbacker eirikbacker converted this from a draft issue Sep 9, 2024
@mimarz
Copy link
Collaborator

mimarz commented Sep 9, 2024

What about container queries? https://css-tricks.com/css-container-queries/

@eirikbacker eirikbacker mentioned this issue Sep 9, 2024
Merged
@eirikbacker
Copy link
Contributor Author

What about container queries? https://css-tricks.com/css-container-queries/

Maybe, but a challenge is that wrapping-point is wildly different based on amount of shown items, so optimally we would like something like https://ishadeed.com/article/flex-wrap-detect/ which does not exist yet 😄

eirikbacker added a commit that referenced this issue Sep 13, 2024
@eirikbacker
fix(Pagination): start converting to new css principles (#2395)
037255c 
- Part of #2295 
- Wraps pagination for now, but should be looked more into #2396
- Skipping #2283 for now to avoid too large PR
- Renames `Pagination.Content` to `Pagination.List` following #2221
- Fixes so `Button` with `hidden` attribute is actually hidden ☺️
@eirikbacker eirikbacker self-assigned this Sep 19, 2024
@eirikbacker eirikbacker moved this from 🔵 Inbox to 🏗 In progress in Team Design System Sep 19, 2024
@eirikbacker eirikbacker mentioned this issue Sep 19, 2024
Merged
@eirikbacker eirikbacker removed their assignment Sep 23, 2024
@mimarz mimarz added the react @digdir/designsystemet-react label Sep 25, 2024
@mimarz
Copy link
Collaborator

mimarz commented Sep 25, 2024

Is this solved in #2460 @eirikbacker ?

@eirikbacker
Copy link
Contributor Author

No @mimarz - this is a separate issue ☺️

@eirikbacker eirikbacker removed their assignment Nov 26, 2024
@eirikbacker eirikbacker moved this from 📄 Todo to 📋 Backlog in Team Design System Nov 26, 2024
@eirikbacker
Copy link
Contributor Author

Venter til etter v1 - ikke et krav for funksjonalitet og ganske styr å implementere og kanskje enklere som web component. Pagination wrapper allerede, den bare justerer ikke ned antall knapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
react @digdir/designsystemet-react
Projects
Team Design System
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eirikbacker @mimarz