Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography classes: Auto-generating or not? #2353

Closed
mrosvik opened this issue Aug 29, 2024 · 3 comments
Closed

Typography classes: Auto-generating or not? #2353

mrosvik opened this issue Aug 29, 2024 · 3 comments
Assignees
Labels
🕵️ investigate Needs investigation

Comments

@mrosvik
Copy link
Member

mrosvik commented Aug 29, 2024

No description provided.

@mrosvik mrosvik added the 🕵️ investigate Needs investigation label Aug 29, 2024
@github-project-automation github-project-automation bot moved this to 🔵 Inbox in Team Design System Sep 2, 2024
@Barsnes
Copy link
Member

Barsnes commented Sep 5, 2024

I don't see how we can easily get a 1-1 with Figma and css if we don't autogenerate this.
If we autogenerate classes based on settings that come from Figma, we make sure these are always in sync, and makes it easy for consumers to use typography classes wherever they want to.

Another plus is that we can expose a script that also does this for our consumers, should they want to change anything about typography

@mimarz
Copy link
Collaborator

mimarz commented Sep 6, 2024

After a discussion with @Barsnes @eirikbacker @unekinn we decided to remove the use of classes and instead create individual css variables for each for the props of the composite typography.

@eirikbacker eirikbacker moved this from 📄 Todo to 🏗 In progress in Team Design System Sep 18, 2024
@eirikbacker eirikbacker moved this from 🏗 In progress to 👀 Ready for review in Team Design System Sep 18, 2024
@mimarz
Copy link
Collaborator

mimarz commented Sep 19, 2024

This was solved in #2429

@mimarz mimarz closed this as completed Sep 19, 2024
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕵️ investigate Needs investigation
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants