Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding top and bottom to the Button component #1726

Closed
Tracked by #1712
mrosvik opened this issue Mar 21, 2024 · 7 comments · Fixed by #1910
Closed
Tracked by #1712

Add padding top and bottom to the Button component #1726

mrosvik opened this issue Mar 21, 2024 · 7 comments · Fixed by #1910
Assignees
Labels
🤝 Help wanted react @digdir/designsystemet-react

Comments

@mrosvik
Copy link
Member

mrosvik commented Mar 21, 2024

When Button has multiple line with text, there should be a top and bottom padding.

Image

@Barsnes
Copy link
Member

Barsnes commented Mar 21, 2024

This is blocked by #1696, or should be done in that PR directly.

@mimarz
Copy link
Collaborator

mimarz commented Apr 9, 2024

This might break Button used as an "icon button". Make sure to test the stories and judge how it looks.

Most likely a BREAKING CHANGE for our users as it changes current expected behaviour.

@mimarz
Copy link
Collaborator

mimarz commented Apr 9, 2024

Which spacing token should this padding be @mrosvik ?

Like these?
#1712 (comment)

@mrosvik
Copy link
Member Author

mrosvik commented Apr 29, 2024

Small
padding top and bottom: spacing-2

Medium
padding top and bottom: spacing-3

Large
padding top and bottom: spacing-3


Could this wait until after V1?

@mimarz
Copy link
Collaborator

mimarz commented Apr 29, 2024

Small padding top and bottom: spacing-2

Medium padding top and bottom: spacing-3

Large padding top and bottom: spacing-3

Could this wait until after V1?

spacing-3 does not work with medium Button as its forces if bigger in combination with text size.

image

@mimarz
Copy link
Collaborator

mimarz commented Apr 29, 2024

@mrosvik Reduced it to spacing-2 for medium, you can have a look here: https://storybook-pr-1910.dev.designsystemet.no/

@mrosvik
Copy link
Member Author

mrosvik commented May 3, 2024

LGTM :)

Large
image

Medium:
image

Small:
image

@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Design System May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤝 Help wanted react @digdir/designsystemet-react
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants