fix: enable noAccumulatingSpread in biome

digdir · Aug 15, 2024 · feb0950 · feb0950
1 parent bed9283
commit feb0950
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/biome.jsonc b/biome.jsonc
@@ -76,9 +76,6 @@
       "suspicious": {
         "noArrayIndexKey": "off",
         "noDoubleEquals": "off" // TODO: Enable this rule
-      },
-      "performance": {
-        "noAccumulatingSpread": "off" // TODO: Enable this rule
       }
     },
     "ignore": []

diff --git a/packages/cli/src/tokens/formats/css.ts b/packages/cli/src/tokens/formats/css.ts
@@ -148,11 +148,10 @@ export const typography: Format = {
     font-weight: ${getValue<string>(token)};
   }`;
 
-            return {
-              ...acc,
+            return Object.assign({}, acc, {
               variables: [...acc.variables, format(token)],
               classes: [...acc.classes, className],
-            };
+            });
           }
 
           if (typeEquals('lineheight', token)) {
@@ -161,11 +160,10 @@ export const typography: Format = {
     line-height: ${getValue<string>(token)};
   }`;
 
-            return {
-              ...acc,
+            return Object.assign({}, acc, {
               variables: [...acc.variables, format(token)],
               classes: [...acc.classes, className],
-            };
+            });
           }
 
           if (typeEquals('typography', token)) {
@@ -194,10 +192,10 @@ export const typography: Format = {
     ${letterSpacingVar ? `letter-spacing: ${letterSpacingVar};` : ''}
   }`;
 
-            return { ...acc, classes: [className, ...acc.classes] };
+            return Object.assign({}, acc, { classes: [className, ...acc.classes] });
           }
 
-          return { ...acc, variables: [...acc.variables, format(token)] };
+          return Object.assign({}, acc, { variables: acc.variables.concat(format(token)) });
         },
         { variables: [], classes: [] },
       ),

diff --git a/packages/react/src/components/Table/Table.stories.tsx b/packages/react/src/components/Table/Table.stories.tsx
@@ -208,7 +208,8 @@ export const WithFormElements: Story = (args) => {
     setHeaderChecked(event.target.checked);
     setCheckedItems(
       rows.reduce(
-        (acc: CheckedItems, row) => ({ ...acc, [row]: event.target.checked }),
+        (acc: CheckedItems, row) =>
+          Object.assign(acc, { [row]: event.target.checked }),
         {},
       ),
     );