Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploring the Functionality of a Close Button for Animation Conflicts #41

Open
SJFCS opened this issue Sep 24, 2024 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@SJFCS
Copy link

SJFCS commented Sep 24, 2024

Terminal wake-up animation conflicts with compiz-alike-magic-lamp-effect extended settings.
This results in a two-blink animation.
Is this possible to provide an animated close button to use the system global animation settings?

@diegodario88
Copy link
Owner

Thanks for pointing this out! Just to clarify—when you mention the close animation, are you referring to the terminal’s "wake-up" or open animation conflicting with the compiz-alike-magic-lamp-effect, or are you specifically asking about adding an animated close button?

@SJFCS
Copy link
Author

SJFCS commented Sep 26, 2024

Thanks for pointing this out! Just to clarify—when you mention the close animation, are you referring to the terminal’s "wake-up" or open animation conflicting with the compiz-alike-magic-lamp-effect, or are you specifically asking about adding an animated close button?

Thank you for your prompt reply
If possible I would like to have a button to turn off the animation.
would you adding an animated close button?

@diegodario88
Copy link
Owner

would you adding an animated close button?

I think that's out of the scope of this project.

@SJFCS
Copy link
Author

SJFCS commented Sep 28, 2024

would you adding an animated close button?

I think that's out of the scope of this project.

I mean set a button to turnoff the terminal popup animation of the project itself
here:

* Toggles the visibility of the terminal window with animations.
* @returns {Promise<void>} A promise that resolves when the toggle operation is complete.
*/
async toggle() {
if (
this._internalState === Util.TERMINAL_STATE.READY ||
this._terminal.state === Util.SHELL_APP_STATE.STOPPED
) {
try {
await this._launchTerminalWindow();
this._adjustTerminalWindowPosition();
} catch (error) {
console.error(error);
this.destroy();
}
}

@diegodario88
Copy link
Owner

I understand. That is achievable if someone is willing to put in the effort. I would be happy to review it.

@diegodario88 diegodario88 added the enhancement New feature or request label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants