Merge TripleStoreKnowledgeBase and TripleStore #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demirrr
requested changes
Nov 29, 2024
| assert h | ||
| assert DLSyntaxObjectRenderer().render(h) | ||
| save_owl_class_expressions(h) | ||
| sparql = Owl2SparqlConverter().as_query("?x", h) | ||
| assert sparql | ||
| else: | ||
| pass | ||
| """ | ||
|
|
There was a problem hiding this comment.
Remove
if name == "main":
test_triplestore = TestTriplestore()
test_triplestore.test_remote_triplestore_dbpedia_tdl()
No need these three lines.
| @@ -53,12 +52,16 @@ def test_remote_triplestore_dbpedia_tdl(self): | |||
| typed_neg = set(map(OWLNamedIndividual, map(IRI.create, examples["negative_examples"]))) | |||
| lp = PosNegLPStandard(pos=typed_pos, neg=typed_neg) | |||
| h = model.fit(learning_problem=lp).best_hypotheses() | |||
| print(h) | |||
| @@ -53,12 +52,16 @@ def test_remote_triplestore_dbpedia_tdl(self): | |||
| typed_neg = set(map(OWLNamedIndividual, map(IRI.create, examples["negative_examples"]))) | |||
| lp = PosNegLPStandard(pos=typed_pos, neg=typed_neg) | |||
| h = model.fit(learning_problem=lp).best_hypotheses() | |||
| print(h) | |||
| assert h | |||
| assert DLSyntaxObjectRenderer().render(h) | |||
| save_owl_class_expressions(h) | |||
| sparql = Owl2SparqlConverter().as_query("?x", h) | |||
| assert sparql | |||
| else: | |||
| pass | |||
There was a problem hiding this comment.
pass is problematic. This is not a really test
|
|
||
| def __init__(self, url: str=None): | ||
| assert url is not None, "url must be string" | ||
| self.g = TripleStoreReasonerOntology(url=url) |
There was a problem hiding this comment.
This is incorrect. We cannot have TripleStoreOntology, TripleStoreReasoner, and TripleStoreReasonerOntology, can we ?
|
I thought merging was putting them together so we don't have two defined
classes. I did not define new functions, but merged already existing ones.
…On Fri, Nov 29, 2024, 11:22 Caglar Demir ***@***.***> wrote:
***@***.**** requested changes on this pull request.
You didn't really merge TripleStoreKnowledgeBase and TripleStore but
rather put already defined class of TripleStoreKnowledgeBase into
TripleStore. What is the benefits of this ?
------------------------------
In tests/test_triplestore.py
<#497 (comment)>:
> assert h
assert DLSyntaxObjectRenderer().render(h)
save_owl_class_expressions(h)
sparql = Owl2SparqlConverter().as_query("?x", h)
assert sparql
else:
pass
- """
+
Remove
if *name* == "*main*":
test_triplestore = TestTriplestore()
test_triplestore.test_remote_triplestore_dbpedia_tdl()
No need these three lines.
------------------------------
In tests/test_triplestore.py
<#497 (comment)>:
> @@ -53,12 +52,16 @@ def test_remote_triplestore_dbpedia_tdl(self):
typed_neg = set(map(OWLNamedIndividual, map(IRI.create, examples["negative_examples"])))
lp = PosNegLPStandard(pos=typed_pos, neg=typed_neg)
h = model.fit(learning_problem=lp).best_hypotheses()
+ print(h)
No need to print
------------------------------
In tests/test_triplestore.py
<#497 (comment)>:
> @@ -53,12 +52,16 @@ def test_remote_triplestore_dbpedia_tdl(self):
typed_neg = set(map(OWLNamedIndividual, map(IRI.create, examples["negative_examples"])))
lp = PosNegLPStandard(pos=typed_pos, neg=typed_neg)
h = model.fit(learning_problem=lp).best_hypotheses()
+ print(h)
assert h
assert DLSyntaxObjectRenderer().render(h)
save_owl_class_expressions(h)
sparql = Owl2SparqlConverter().as_query("?x", h)
assert sparql
else:
pass
pass is problematic. This is not a really test
------------------------------
In ontolearn/triple_store.py
<#497 (comment)>:
>
+ def __init__(self, url: str=None):
+ assert url is not None, "url must be string"
+ self.g = TripleStoreReasonerOntology(url=url)
This is incorrect. We cannot have TripleStoreOntology,
TripleStoreReasoner, and TripleStoreReasonerOntology, can we ?
—
Reply to this email directly, view it on GitHub
<#497 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK4X4ERYEY6CRNJYVD6ODRT2DA57DAVCNFSM6AAAAABSOIIVOGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINRZGU3TQOBRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented a simple merge of TripleStore and TripleStoreKnowledgeBase. Tests work locally. Please review and merge