Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTEXT.md #846

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Update CONTEXT.md #846

merged 4 commits into from
Sep 11, 2024

Conversation

elboyran
Copy link
Contributor

Why DIANNA in the documentation was obsolete.

@elboyran elboyran requested a review from cwmeijer August 23, 2024 13:11
@elboyran elboyran self-assigned this Aug 23, 2024
@elboyran elboyran linked an issue Aug 23, 2024 that may be closed by this pull request
@elboyran
Copy link
Contributor Author

elboyran commented Aug 23, 2024

No idea, why the link checker thinks the TF link is dead- it isn't. I guess the dashboard test failing will be solved eventually by @laurasootes in #844 or related PR.

Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update indeed. I have some recommendation about the dashboard description, not being in a state for a user to work with their own model and/or data.

docs/CONTEXT.md Outdated Show resolved Hide resolved
docs/CONTEXT.md Outdated Show resolved Hide resolved
docs/CONTEXT.md Outdated Show resolved Hide resolved
elboyran and others added 3 commits September 9, 2024 10:34
Co-authored-by: Christiaan Meijer <[email protected]>
Co-authored-by: Christiaan Meijer <[email protected]>
Co-authored-by: Christiaan Meijer <[email protected]>
@elboyran elboyran requested a review from cwmeijer September 9, 2024 08:37
Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elboyran
Copy link
Contributor Author

It also depends on the outcome of #848.

@elboyran elboyran merged commit d953282 into main Sep 11, 2024
13 of 17 checks passed
@elboyran elboyran deleted the 845-update-why-dianna branch September 18, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Why DIANNA?
2 participants