-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
818 dashboard modify input data section for multiple examples #831
818 dashboard modify input data section for multiple examples #831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laurasootes thanks for adding clear explanations for each example 🥇 . Some text used in test_dashboard.py
should be changed accordingly, for example this one.
Also, I noticed a title is set for each page as st.title('Image explanation')
or st.title('Time series explanation')
, .... Can we make them more informative? 🤔
I fixed some line too long
errors, but let's check if there are other linter errors. Can you please run ruff check
on the changed files?
…i/dianna into 818-dashboard-modifu-input-data-section-for-multiple-examples
hi @SarahAlidoost, thanks for your review. I updated the dashboard tests accordingly and checked the line lengths, after your fixes they are all good now. I agree with your comment about the page title. I have added it to issue #816 where in which all tetx-related things will be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laurasootes thanks for addressing the comments. Changes look good 👍 Before merging, can you please change the base branch of this pull request from 817-dashboard-move-menu
to main
. Because #830 is already merged. Also, only after changing the base to main
, github action will run automatically on this pull request.
This PR a specifications for each example in the dashboard in the left menu (fixes #818).
Additionally, upon example selection, text will be shown explaining what the example is (adds to #816 and #819)
Please check if the explanatory text is sufficient.