fix ruff invocation in linting workflow #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the torchtext failures seem unrelated as mentioned in #827. The only workflow that matters is the one that actually does work again now: the linting one :) https://github.com/dianna-ai/dianna/actions/runs/10145802048/job/28052379417?pr=828 |
It said: warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`: - 'dummy-variable-rgx' -> 'lint.dummy-variable-rgx' - 'fixable' -> 'lint.fixable' - 'ignore' -> 'lint.ignore' - 'select' -> 'lint.select' - 'unfixable' -> 'lint.unfixable' - 'isort' -> 'lint.isort' - 'per-file-ignores' -> 'lint.per-file-ignores' Fixed it the same way as in the Python template (NLeSC/python-template@3ce8ff9)
Co-authored-by: Stef Smeets <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all. The linting workflow is broken, this fixes it (I hope).