Unbreak CMake build #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to HDF5-1.14.4-2 as per Makefile because CBFlib needs H5allocate_memory(), introduced in HDF5-1.8.15. Create hdf5 target for shared HDF5; anything linking against it must be compiled with H5_USE_110_API. HDF5 is a public dependency of CBFlib. * cif2cbf now depends on CQRlib, patch it for CMake support and link against the shared library. * Introduce a target for PCRE and also find shared library. A static libpcreposix requires libpcre. PCRE is a private dependencies of CBFlib. Tested with CMake 3.25.1 on Debian Bookworm (WSL).
Not used, largely redundant with CMakeLists.txt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes 61 out of 90 (68%) CTest tests, but at least it runs. More to come…