Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing some external_data items after merge into mainline #46

Open
jamesrhester opened this issue May 6, 2022 · 0 comments
Open

Missing some external_data items after merge into mainline #46

jamesrhester opened this issue May 6, 2022 · 0 comments

Comments

@jamesrhester
Copy link

The latest version of cif_img.dic in the doc directory is 1.8.5, which (among other things) should contain the external data pointer work that was in jrh_ext_data branch. Comparing the two and correcting for the move to the array_data_external_data category, the following data names are missing and should be added back:

  1. _array_data.external_archive_path -> _array_data_external_data.archive_path

This describes the location of a file within an archive. It is distinct from _array_data_external_data.path which describes the location of a frame within a file, e.g. a location within an HDF5 file, which itself might be part of a larger archive.

  1. _array_data.external_archive_format -> _array_data_external_data.archive_format

This gives the format of the archive (e.g. .tar.gz) within which the file containing the frame is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant