Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for longer task log text #8

Open
dashmage opened this issue Jul 22, 2024 · 2 comments
Open

Support for longer task log text #8

dashmage opened this issue Jul 22, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@dashmage
Copy link
Contributor

While adding a task log entry with longer length, part of the text ends up getting truncated. This also happens when viewing them with hours log. It would be nice if the text were to scroll somehow or spill over to an additional line. But I can also imagine this as a feature where you expect the user to be able to concisely describe the task log?

task log list with a long entry
image

output of hours log
image

As an aside, is there any way to edit the task log once created? Similar to updating a task description when pressingu?

@dashmage dashmage added the enhancement New feature or request label Jul 22, 2024
@dhth
Copy link
Owner

dhth commented Aug 3, 2024

You are correct in assuming that task log comments are intended to be concise. I'll see if I can make a task log comment take more than 1 line, and still keep the UI visually consistent, but my hunch is that it might make pagination much more of a hassle (right now each entry takes the same height (2 lines), so paginating entries is straightforward). Doing this for the log output might be comparatively easier.

If it makes sense, I might increase the max length for a task log comment (make it a paragraph instead of a line), and add another view (accessible via a single key, say "d") which shows the full comment in a pager.

Support for updating a task log entry is being worked in #11. I've also removed the trimming of task log comments in the task log list view.
image

@dhth dhth added this to the v0.4.0 milestone Aug 3, 2024
@dashmage
Copy link
Contributor Author

dashmage commented Aug 3, 2024

You are correct in assuming that task log comments are intended to be concise. I'll see if I can make a task log comment take more than 1 line, and still keep the UI visually consistent, but my hunch is that it might make pagination much more of a hassle (right now each entry takes the same height (2 lines), so paginating entries is straightforward). Doing this for the log output might be comparatively easier.

Totally understand, I think it's good practice either way to keep the task log comment short and descriptive. It would be great if we could have the longer line support just for the task log output (hours log) if that might be simpler for the occasional long entry.

If it makes sense, I might increase the max length for a task log comment (make it a paragraph instead of a line), and add another view (accessible via a single key, say "d") which shows the full comment in a pager.

I do sometimes find myself wanting to write an additional line or 2 for some entries which need more context. So if implemented, this would be quite useful actually.

Support for updating a task log entry is being worked in #11. I've also removed the trimming of task log comments in the task log list view.

That's great. Thanks so much! I've been using hours for a while now and it's a super productive part of my workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants