Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Species Name column doesn't accept multiple rows with same name #17

Open
dhornbein opened this issue Apr 14, 2014 · 1 comment
Open
Labels

Comments

@dhornbein
Copy link
Owner

If a row has the same name it will only render a single instance. This relates to issues #12 and how we handle multiple phenological events for a single species.

The usecase

I have a planting chart for Hill Forest Farm (link to gDoc). Each plant on the chart should have sew outdoors and harvest event plus a possible sew inside event.

It seems to me that each of these events should appear on the same line.

Bug

There can't be multiple instances of the same name, the previous one's get overwritten. It's not clear to me where in the code this could be happening.

To reporduce

Use a spreadsheet with two identical entries in the name column. Only one will show up on the clock!

@thiagodemellobueno
Copy link
Collaborator

They are not actually related issues programatically.

We are currently storing species in arrays with the ‘slug as index’ so when species[‘aName’] = blah happens, that species gets completely overwritten.
This does make it easy to say ‘get data by name’ a simple solution is to store the species in a plain array, it just makes the pulling out of a specie a little harder.
An Id columm would solve this (but maybe unecessary).

However thats not how we are storing ‘events’ (or phenophases)… they do not need unique names.

On Apr 14, 2014, at 12:17 AM, Drew [email protected] wrote:

If a row has the same name it will only render a single instance. This relates to issues #12 and how we handle multiple phenological events for a single species.

The usecase

I have a planting chart for Hill Forest Farm (link to gDoc). Each plant on the chart should have sew outdoors and harvest event plus a possible sew inside event.

It seems to me that each of these events should appear on the same line.

Changing the spreadsheet in this way is somewhat problematic, the spec before had each species as an entry, not each event.
This changes the data structure dramatically. We certainly have to choose a single way of doing this.
Is there a specific need that arose that necessitated this data shift? What wasn’t working about the old model?

Bug

There can't be multiple instances of the same name, the previous one's get overwritten. It's not clear to me where in the code this could be happening.

This is not a bug, you took an app that expected one set of data, and supplied it with a completely different set of data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants