Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: decoding fail when entering password #22

Open
efim-a-efim opened this issue Jul 17, 2018 · 2 comments
Open

Windows: decoding fail when entering password #22

efim-a-efim opened this issue Jul 17, 2018 · 2 comments

Comments

@efim-a-efim
Copy link

I use VSCode on Windows. When trying to use this extension without storing password on filesystem (e.g. entering password each time it's required), I face the following error:

Command failed: touch C:\Users\User\AppData\Local\Temp\tmp-57692Jab9WhG31WYX && echo "PassWord" > C:\Users\User\AppData\Local\Temp\tmp-57692Jab9WhG31WYX 'touch' is not recognized as an internal or external command, operable program or batch file.

It's an expected behavior, because Windows doesn't have Unix commands natively.

My offer is to use TypeScript/JS native ways to write files (e.g. fs module) - this will resolve all possible cross-platform problems.

@efim-a-efim
Copy link
Author

efim-a-efim commented Jul 17, 2018

Also after looking at the code, I see that there's some kind of "path magic" like:

let keyfile = config.keyfile.trim("/");
keyfile = keyfile.trim("/");

It's not cross-platform, on Windows path separator is \, not /. It should be OK to remove this code and print an error when someone puts incorrect path there.

@tvories
Copy link

tvories commented Sep 11, 2018

I'm having the same issue here. It would be nice to be able to use this on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants