-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomplete list of dependencies #3
Comments
Hello @ivyleavedtoadflax, thank you for your interest and for testing the code out. Requirements are specified in each sub-folder separately. I agree it would be better to have a single |
Hi @Giovanni1085 I will happily add a requirements, but I could not get the software to work without one at present. I'd quite like to try to model, so will have a play with it and see if I can get it working with more contemporary versions. |
Also @Giovanni1085, I see you're at the Turing. Do let me know if you fancy grabbing a coffee at some point when you're in London. |
Unfortunately some of the packages we use do not install very straightforwardly. The versions of the packages we use are listed in each folder of the repository, see: You can try the following:
Please let me know if this works. Regarding meeting in person, please write me an email. |
Thanks, I did try this with pip, but I needed to download the tars for |
@ivyleavedtoadflax were you ultimately successful in running the code or not yet? If not, please let me know if I may help, or I'll close the issue and consider it solved. Thanks. |
Hi @Giovanni1085, I'm on holiday at the moment, bit will try again next week. Thanks 👍 |
Unfortunately, your instructions failed on
Attempting to install from the archive with
I've experimented with a few things:
This gives:
I also tried with docker to rule out local issues with the following Dockerfile:
This also fails with a similar error:
I also tried various other versions of tensorflow from 1.0.0 to 1.14.0. All fail to install. |
So I've had some success running keras/main_ThreeTasks.py using the following dependecies in python 3.7.0, but i needed to change the lines described in #4.
@Giovanni1085 there's a few more things that will need adjusting, but would you like me submit a PR for usin gthe model with python 3.7.0? |
@ivyleavedtoadflax excellent. Yes please, once you're happy with the results, feel welcome to add a how to section in the relevant README file (e.g., keras/README.md in this case) as a PR. |
Great, will do 👍
|
Done in #7 . I'm going to continue to experiment with the other models, so probably push a fix for the CRF and multitask models soon too. Thanks for all your work on getting this out there @Giovanni1085 💯 |
Hi @Giovanni1085 many thanks for publishing this code, and your very useful paper.
unfortunately I'm having several issues getting it run on my machine. I suspect much of it is caused by not having a complete list of dependencies. Would you consider adding a more comprehensive list in a
requirements.txt
?I'll document the issues I'm having in some other issues.
The text was updated successfully, but these errors were encountered: