Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming consistency #165

Open
chang-trivariate opened this issue Dec 18, 2024 · 2 comments
Open

Naming consistency #165

chang-trivariate opened this issue Dec 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@chang-trivariate
Copy link

Maybe it is better to use accession_number as key instead of accession_no to be consistent with the naming in filings.to_dict and filings.to_pandas?

def to_dict(self) -> Dict[str, Union[str, int]]:
    """Return the filing as a Dict string"""
    return {'accession_no': self.accession_no,
            'cik': self.cik,
            'company': self.company,
            'form': self.form,
            'filing_date': self.filing_date}
@dgunning
Copy link
Owner

Good point. Will likely do that but first Ineed ton check if there could be anyone that depends on that name

@dgunning dgunning added the enhancement New feature or request label Dec 18, 2024
@dgunning
Copy link
Owner

Fix made in commit/fdee86

Released in 3.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants