Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: disabled Testnet BTC API warning #3830

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Conversation

jessiemongeon1
Copy link
Collaborator

Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.

If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:

@jessiemongeon1 jessiemongeon1 requested a review from a team as a code owner December 2, 2024 18:03
@github-actions github-actions bot added the documentation Changes to Developer Docs label Dec 2, 2024
Copy link
Member

@marc0olo marc0olo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessiemongeon1 I would replace "in the future" with "soon". maybe we can also add a link to the forum discussion.

@jessiemongeon1
Copy link
Collaborator Author

@marc0olo I think "soon" is too relative. I'll add a link to the forum.

@marc0olo
Copy link
Member

marc0olo commented Dec 3, 2024

@marc0olo I think "soon" is too relative. I'll add a link to the forum.

@jessiemongeon1 typically I agree, but we know it is ~2 weeks to arrive. "in the future" implies to me that it might take a long time. maybe "in the near future" is the way to go 🤔

but anyway, I am fine with everything 😁 👍

@jessiemongeon1 jessiemongeon1 enabled auto-merge (squash) December 3, 2024 01:37
@jessiemongeon1 jessiemongeon1 merged commit 01abe34 into master Dec 3, 2024
5 checks passed
@jessiemongeon1 jessiemongeon1 deleted the update-btc-tutorial branch December 3, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes to Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants