Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: assert event.source equals popup #291

Merged
merged 4 commits into from
Oct 16, 2024
Merged

feat: assert event.source equals popup #291

merged 4 commits into from
Oct 16, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

We want to assert that the event source which respond to the relying party is the popup.

@peterpeterparker peterpeterparker requested a review from a team as a code owner October 15, 2024 13:41
frederikrothenberger
frederikrothenberger approved these changes Oct 16, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@peterpeterparker peterpeterparker merged commit 286c6f0 into main Oct 16, 2024
9 checks passed
@peterpeterparker peterpeterparker deleted the feat/source-popup branch October 16, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

@tmu0 tmu0 Awaiting requested review from tmu0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @frederikrothenberger